Re: [ng-spice] History and command completion


To ng-spice@ieee.ing.uniroma1.it
From widlok <widlok@uci.agh.edu.pl>
Date Wed, 08 Nov 2000 09:23:28 +0100
Delivered-To mailing list ng-spice@ieee.ing.uniroma1.it
Mailing-List contact ng-spice-help@ieee.ing.uniroma1.it; run by ezmlm
References <Pine.LNX.3.96.1001106092905.3794A-100000@ieee.ing.uniroma1.it > <00110618155100.01796@leipc8 > <3A07DB9F.13D87299@uci.agh.edu.pl > <20001107185323.A24490@cgmd80028.chello.nl >
Reply-To ng-spice@ieee.ing.uniroma1.it

Hi,

>
> I have applied your patches.  I did change your C++ style comments to
> C style comments.  This keeps a uniform style.
>
> I also removed all the code between #ifdef notdef ... #endif.  No need
> to clutter up code by something that never gets executed.
>

Right, I will make my patches in this way next time, thanks.

Question for all:
    Who have been changing variable.c ? This version causes immediate core
dumps on startup. Looked at it this mooring and I see typical bugs there,
like:
    copyval = cp_unquote(val);
    strcpy(val, copyval);
    txfree(copyval);

Good, memory leak seems to be fixed, but cp_unquote() does not return malloc
pointer, and then txfree() fails. Anyway this should be done more optimal
like:
    copyval = val;
    val = cp_unquote(val);
    txfree(copyval);

And even now one should change cp_unqoute() to make it returns 'good' malloc
pointer.
I think that I will fix some of them to make spice to work (I need it NOW),
but please test Yours patches.

Michael.


Partial thread listing: