Re: [ng-spice] History and command completion
Hi,
>
> I have applied your patches. I did change your C++ style comments to
> C style comments. This keeps a uniform style.
>
> I also removed all the code between #ifdef notdef ... #endif. No need
> to clutter up code by something that never gets executed.
>
Right, I will make my patches in this way next time, thanks.
Question for all:
Who have been changing variable.c ? This version causes immediate core
dumps on startup. Looked at it this mooring and I see typical bugs there,
like:
copyval = cp_unquote(val);
strcpy(val, copyval);
txfree(copyval);
Good, memory leak seems to be fixed, but cp_unquote() does not return malloc
pointer, and then txfree() fails. Anyway this should be done more optimal
like:
copyval = val;
val = cp_unquote(val);
txfree(copyval);
And even now one should change cp_unqoute() to make it returns 'good' malloc
pointer.
I think that I will fix some of them to make spice to work (I need it NOW),
but please test Yours patches.
Michael.
Partial thread listing:
- Re: [ng-spice] History and command completion, (continued)