Re: [ng-spice-devel] Patches
Paolo Nenzi wrote:
>
> Send me the files and I will do the necessary integration into the CVS.
>
Done. Now that it's mostly (if not fully) working, I'll try to look over
all the fixes, check that they've transferred successfully, and try
to write some documentation for each one. There's quite a lot
changed, and not much clue as to why it was done and how it works.
That's my fault. You've been very trusting with my changes. I
could be giving you a lot of rubbish ;-)
By the way, about documentation/changes and things, I found that
using the #ifdef statements around the new code, leaving the original
code next to it, was a useful part of the documentation process
(especially since I didn't do any documentation ;-) With CVS, I can
see that that the #ifdef's will not be necessary in order to revert to
uncorrected code, but it's sometimes useful, if not essential, to be
able to take the fixes out, 'cos often you'll come up against an old
circuit that used to work, but the "fixes" have stopped it.
I've noticed in at least one place, there's an #ifdef EXPERIMENTAL
(in traninit.c I think). Do we have any conventions or opinions
about this ?
Cheers,
Alan
Partial thread listing:
- Re: [ng-spice-devel] Patches, (continued)