x11.c: #ifdef notdef


To ng-spice-devel <ng-spice-devel@ieee.ing.uniroma1.it>
From "Arno W. Peters" <a.w.peters@ieee.org>
Date Thu, 25 May 2000 23:29:59 +0200
Delivered-To mailing list ng-spice-devel@ieee.ing.uniroma1.it
Mailing-List contact ng-spice-devel-help@ieee.ing.uniroma1.it; run by ezmlm
Reply-To ng-spice-devel@ieee.ing.uniroma1.it
User-Agent Mutt/1.2i

Paolo,

I saw you have put back some code I had deleted.  Namely code that was
surrounded with

  #ifdef notdef

    ...

  #endif

I must object to this.  Please choose your preprocessor defines to be
meaningful.  This for the following reasons:

 o If you want some code to have special functionality compiled in,
 define that preprocessor variable and be done with it.

 o A special purpose preprocessor define won't interfere with other
 conditionally compiled code.

 o It also make it clear to the reader of the code what it the
 #ifdef/#endif code actually tries to accomplish.  For example:

  #ifdef SPECIALLINESTYLES

    ...

  #endif

 From this piece of code it is immediately clear that we try to do
 something funky with linestyles.


I deleted the code because to me it was not clear it was used in any
way.  So, if you would like to keep the code from my periodic cleaning
rages, please adjust these preprocessor defines.


Regards,
-- 
Arno

PGP signature


Partial thread listing: